Skip to content

Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 4 | Implement shell tools python#512

Open
TarasMykytiuk wants to merge 3 commits into
CodeYourFuture:mainfrom
TarasMykytiuk:implement_shell_tools_python
Open

Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 4 | Implement shell tools python#512
TarasMykytiuk wants to merge 3 commits into
CodeYourFuture:mainfrom
TarasMykytiuk:implement_shell_tools_python

Conversation

@TarasMykytiuk
Copy link
Copy Markdown

@TarasMykytiuk TarasMykytiuk commented Apr 27, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implement shell tools python exercises are done.

@TarasMykytiuk TarasMykytiuk added 📅 Sprint 4 Assigned during Sprint 4 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Tools The name of the module. labels Apr 27, 2026
@TarasMykytiuk TarasMykytiuk changed the title Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 5 | Implement shell tools python Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 4 | Implement shell tools python Apr 27, 2026
Copy link
Copy Markdown
Contributor

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but there is some work left to do here.

Is there a package you could use to help with managing arguments? Right now it is a bit complex, and you can't combine single-letter arguments like the command line tools.



def addColorToStr(color, str):
reset = "\033[0m"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea to experiment with this

path = item
scanResult = os.scandir(path)
isHiddenToShow = "-a" in flags
isStatsToList = "-l" in flags
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-read the readme file? Are you sure it is asking for the -l argument?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Tools The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 4 Assigned during Sprint 4 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants